Skip to content

Use location directoryPath in isHierarchicalNamespaceEnabled check #25457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

lohart13
Copy link
Contributor

@lohart13 lohart13 commented Mar 30, 2025

Description

Use location directoryPath in isHierarchicalNamespaceEnabled check to fix error on Microsoft OneLake destinations.

Additional context and related issues

Fixes #25453

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Copy link

cla-bot bot commented Mar 30, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Mar 31, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

@github-actions github-actions bot added the stale label May 13, 2025
@electrum electrum merged commit aec2873 into trinodb:master May 20, 2025
60 checks passed
@electrum
Copy link
Member

Thanks!

@github-actions github-actions bot added this to the 476 milestone May 20, 2025
@ebyhr
Copy link
Member

ebyhr commented May 20, 2025

I think this PR broke CI: https://github.com/trinodb/trino/actions/runs/15127714744/job/42522744955

Error:  Errors: 
Error:    TestAzureFileSystemGen2Flat>AbstractTestTrinoFileSystem.testDeleteDirectory:847->AbstractTestTrinoFileSystem.testDeleteDirectory:883 » IO Checking whether hierarchical namespace is enabled for the location abfs://test-flat-264ef1b8-24ce-49f1-bb6c-b54d1a67105d@devcicdflat.dfs.core.windows.net/ failed
Error:    TestAzureFileSystemGen2Flat>AbstractTestAzureFileSystem.testDirectoryExists:285->AbstractTestTrinoFileSystem.testDirectoryExists:1121->AbstractTestTrinoFileSystem.listPath:1365 » IO Checking whether hierarchical namespace is enabled for the location abfs://test-flat-264ef1b8-24ce-49f1-bb6c-b54d1a67105d@devcicdflat.dfs.core.windows.net/ failed
Error:    TestAzureFileSystemGen2Flat>AbstractTestTrinoFileSystem.testFileDoesNotExistUntilClosed:1394->AbstractTestTrinoFileSystem.fileExistsInListing:1478 » IO Checking whether hierarchical namespace is enabled for the location abfs://test-flat-264ef1b8-24ce-49f1-bb6c-b54d1a67105d@devcicdflat.dfs.core.windows.net/ failed
...

@electrum
Copy link
Member

Ugh, I forgot the integration tests don’t run for PRs. I’ll put up a revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

isHierarchicalNamespaceEnabled check for Azure File System fails due to location
3 participants